Wei Huang created YUNIKORN-1694:
-----------------------------------

             Summary: Update go.mod to 1.19
                 Key: YUNIKORN-1694
                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1694
             Project: Apache YuniKorn
          Issue Type: Improvement
          Components: shim - kubernetes
            Reporter: Wei Huang


The latest go.mod pins go version to 1.16, but given it vendors k8s v1.23 
[where|https://github.com/kubernetes/kubernetes/blob/v1.23.17/go.mod#L9] used 
go 1.19, it's better to bump go version to 1.19 as well.

Otherwise, running `go mod vendor` would fail with:
{quote}weih@m1max:~/go/src/github.com/apache/yunikorn-k8shim|master ⇒  go 
version
go version go1.16.15 darwin/arm64
weih@m1max:~/go/src/github.com/apache/yunikorn-k8shim|master ⇒  go mod vendor
internal error: failed to find embedded files of go.uber.org/zap: //go:build 
comment without // +build comment
{quote}
Switching to go1.19 works fine:
{quote}weih@m1max:~/go/src/github.com/apache/yunikorn-k8shim|master ⇒  go 
version
go version go1.19.8 darwin/arm64
weih@m1max:~/go/src/github.com/apache/yunikorn-k8shim|master ⇒  go mod vendor
{quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to