[ 
https://issues.apache.org/jira/browse/YUNIKORN-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714785#comment-17714785
 ] 

Wei Huang commented on YUNIKORN-1703:
-------------------------------------

Context: during writing a unit test for plugin mode's main.go, I met some 
tricky issue:

{{2023-04-20T18:02:00.931-0700    ERROR    shim/scheduler.go:219    failed to 
load yunikorn configmaps    \{"error": "Get 
\"https://127.0.0.1:63633/api/v1/namespaces/default/configmaps/yunikorn-configs\":
 dial tcp 127.0.0.1:63633: connect: connection refused"}}}
{{github.com/apache/yunikorn-k8shim/pkg/shim.(*KubernetesShim).registerShimLayer}}
{{    
/Users/weih/go/src/github.pie.apple.com/aci/kube-scheduler/vendor/github.com/apache/yunikorn-k8shim/pkg/shim/scheduler.go:219}}
{{github.com/apache/yunikorn-k8shim/pkg/shim.(*KubernetesShim).register}}
{{    
/Users/weih/go/src/github.pie.apple.com/aci/kube-scheduler/vendor/github.com/apache/yunikorn-k8shim/pkg/shim/scheduler.go:129}}
{{github.com/apache/yunikorn-k8shim/pkg/shim.newSchedulerState.func5}}
{{    
/Users/weih/go/src/github.pie.apple.com/aci/kube-scheduler/vendor/github.com/apache/yunikorn-k8shim/pkg/shim/scheduler_state.go:170}}
{{github.com/looplab/fsm.(*FSM).afterEventCallbacks}}
{{    
/Users/weih/go/src/github.pie.apple.com/aci/kube-scheduler/vendor/github.com/looplab/fsm/fsm.go:414}}
{{github.com/looplab/fsm.(*FSM).Event.func1}}
{{    
/Users/weih/go/src/github.pie.apple.com/aci/kube-scheduler/vendor/github.com/looplab/fsm/fsm.go:309}}
{{github.com/looplab/fsm.transitionerStruct.transition}}
{{    
/Users/weih/go/src/github.pie.apple.com/aci/kube-scheduler/vendor/github.com/looplab/fsm/fsm.go:354}}
{{github.com/looplab/fsm.(*FSM).doTransition}}
{{    
/Users/weih/go/src/github.pie.apple.com/aci/kube-scheduler/vendor/github.com/looplab/fsm/fsm.go:339}}
{{github.com/looplab/fsm.(*FSM).Event}}
{{    
/Users/weih/go/src/github.pie.apple.com/aci/kube-scheduler/vendor/github.com/looplab/fsm/fsm.go:321}}
{{github.com/apache/yunikorn-k8shim/pkg/shim.(*KubernetesShim).handle}}
{{    
/Users/weih/go/src/github.pie.apple.com/aci/kube-scheduler/vendor/github.com/apache/yunikorn-k8shim/pkg/shim/scheduler.go:257}}
{{github.com/apache/yunikorn-k8shim/pkg/shim.(*KubernetesShim).SchedulerEventHandler.func1}}
{{    
/Users/weih/go/src/github.pie.apple.com/aci/kube-scheduler/vendor/github.com/apache/yunikorn-k8shim/pkg/shim/scheduler.go:118}}
{{github.com/apache/yunikorn-k8shim/pkg/dispatcher.Start.func1}}
{{    
/Users/weih/go/src/github.pie.apple.com/aci/kube-scheduler/vendor/github.com/apache/yunikorn-k8shim/pkg/dispatcher/dispatcher.go:201}}

I guess this is b/c the unit test setup cannot fully simulate a real env, so I 
tried to enable testMode=true to bypass it, but it turns out testMode is 
hard-coded to false.

> testMode is hardcoded to false in NewShimSchedulerForPlugin()
> -------------------------------------------------------------
>
>                 Key: YUNIKORN-1703
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1703
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: shim - kubernetes
>            Reporter: Wei Huang
>            Priority: Trivial
>
> At 
> [https://github.com/apache/yunikorn-k8shim/blob/36040b40c50776e2200f51a85acbfc80aecd99f1/pkg/shim/scheduler.go#L80,]
>  testMode is hard-coded to false, I think we should honor the testMode value 
> in
> configs:
>  
> {{apiFactory := client.NewAPIFactory(scheduler, informerFactory, configs, 
> configs.TestMode)}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to