[
https://issues.apache.org/jira/browse/YUNIKORN-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722649#comment-17722649
]
Wilfred Spiegelenburg commented on YUNIKORN-1351:
-------------------------------------------------
These are the locations that need to be fixed: * GetQueueNameFromPod
*
updatePodLabel (admission controller)
* newPlaceholder
*
isStateAwareDisabled (does not have an annotation equivalent)
Test code will need to be updated to make sure we cover all cases.
> alway prefer annotations above labels
> -------------------------------------
>
> Key: YUNIKORN-1351
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1351
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes
> Reporter: Wilfred Spiegelenburg
> Assignee: Ting Yao,Huang
> Priority: Major
> Labels: newbie
>
> For most values we prefer the annotations above the labels when set on a pod.
> For the queue we prefer the label. We need to make this consistent and always
> prefer annotations. We also need to look at deprecating the labels and move
> everything to annotations using the {{yunikorn.apache.org}} namespace.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
