[
https://issues.apache.org/jira/browse/YUNIKORN-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17723825#comment-17723825
]
Wilfred Spiegelenburg commented on YUNIKORN-1273:
-------------------------------------------------
We should have no issue with a switch that can be set via the config map.
Suggested name for the configuration is _FilteringPrefix +
"generateUniqueAppID"_ which is ‘false’ by default.
The behaviour will match the current generating logic of a namespace based
application ID.
If set to ‘true’ an unique ID will be generated for each pod that does not have
an application ID set.
The filter prefix seems to be the most logical place to add it as the logic to
add an appID is managed by the setting under that prefix.
We have [old
code|https://github.com/apache/yunikorn-k8shim/blob/branch-0.8/pkg/plugin/admissioncontrollers/webhook/admission_controller.go#L128-L135]
that would generate an application ID that was unique and still fits within a
label.
That should be reused As part of the change we should move the existing
{{generateAppID}} to the correct place: {{pkg/admission/util.go}} and hide the
logic based on the config flag in that function.
> Add option to have unique application ids in a namespace
> --------------------------------------------------------
>
> Key: YUNIKORN-1273
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1273
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes
> Reporter: Mit Desai
> Assignee: Mit Desai
> Priority: Major
> Labels: pull-request-available
>
> Currently, if the appId is not explicitly specified (eg: non spark jobs), all
> the pods running in a namespace will be grouped together under a single
> application id that will be derived from the namespace.
> Instead of forcing the pods to be clubbed under a single umbrella, we should
> have an option for the user to decide whether they would like to have
> multiple applications or group them together under a single application
> Design Doc:
> [https://docs.google.com/document/d/17H9FIBIR_p_AlLKFfcnoAlZAzTauBBiCKn0EbmdadH0/edit?usp=sharing]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
