[ 
https://issues.apache.org/jira/browse/YUNIKORN-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Craig Condit resolved YUNIKORN-1650.
------------------------------------
    Fix Version/s: 1.3.0
       Resolution: Fixed

Merged to master. Thanks [~mitdesai] for the contribution. Would you mind also 
opening up a doc PR to yunikorn-site for the new setting? Thanks!

> Add setting for default queue in admission controller
> -----------------------------------------------------
>
>                 Key: YUNIKORN-1650
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1650
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: shim - kubernetes
>            Reporter: Mit Desai
>            Assignee: Mit Desai
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.3.0
>
>
> If the queue name is not defined during the job submission, YuniKorn 
> admission controller will add a default queue to the pod labels.
> When _provided_ placement rule is defined, along with other placement rules, 
> it is possible that only provided placement rule is executed and no other 
> rule is exercised.
> In the following scenario, when there are 3 placement rules defined,
> placementrules:
>         - name: provided
>         - name: tag
>         - name: fixed
> The applications will be placed in the right queue, following the _provided_ 
> rule if the queue is defined during job submission. If the queue is not 
> defined during job submission, admission controller will add a default queue 
> name. This will again trigger the provided rule as the queue name will be 
> found in the pod labels during placement rules execution. As a result, _tag_ 
> and _fixed_ rules will never be executed and all the apps that do not have a 
> queue defined will end up getting placed in the default queue.
> To solve this, we should have a toggle in the admission controller configs 
> whether to add the default queue to or not. Whenever such placement rules are 
> setup, admission controller should be configured to skip adding the default 
> queue name.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to