[
https://issues.apache.org/jira/browse/YUNIKORN-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YUNIKORN-1784:
-----------------------------------
Description:
In various places in Yunikorn, we store time like:
Application:
{noformat}
SubmissionTime time.Time
finishedTime time.Time
startTime time.Time
{noformat}
AllocationLogEntry:
{noformat}
LastOccurrence time.Time
{noformat}
AllocationAsk:
{noformat}
createTime time.Time
{noformat}
In the DAO objects, we convert it back to int64 with {{{}Time.UnixNano(){}}}.
There are calculations at various places (eg.{{{} Since(){}}}, {{{}Sub(){}}}),
but that's simple to solve.
Storing a simple int64 is better because not only it consumes less space,
{{time.Time}} also contains a pointer to a {{Location}} structure which we
don't use.
was:
In various places in Yunikorn, we store time like:
Application:
{noformat}
SubmissionTime time.Time
finishedTime time.Time
startTime time.Time
{noformat}
AllocationLogEntry:
{noformat}
LastOccurrence time.Time
{noformat}
AllocationAsk:
{noformat}
createTime time.Time
{noformat}
It makes no sense to store this as {{time.Time}} type, because we convert it
back to int64 with {{Time.UnixNano()}} in the DAO objects. Storing a simple
int64 is better because not only it consumes less space, {{time.Time}} also
contains a pointer to a {{Location}} structure which we don't use.
> Store time in int64 type instead of time.Time
> ---------------------------------------------
>
> Key: YUNIKORN-1784
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1784
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: core - scheduler
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Major
>
> In various places in Yunikorn, we store time like:
> Application:
> {noformat}
> SubmissionTime time.Time
> finishedTime time.Time
> startTime time.Time
> {noformat}
> AllocationLogEntry:
> {noformat}
> LastOccurrence time.Time
> {noformat}
> AllocationAsk:
> {noformat}
> createTime time.Time
> {noformat}
> In the DAO objects, we convert it back to int64 with {{{}Time.UnixNano(){}}}.
> There are calculations at various places (eg.{{{} Since(){}}},
> {{{}Sub(){}}}), but that's simple to solve.
> Storing a simple int64 is better because not only it consumes less space,
> {{time.Time}} also contains a pointer to a {{Location}} structure which we
> don't use.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
