[ 
https://issues.apache.org/jira/browse/YUNIKORN-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729781#comment-17729781
 ] 

Peter Bacsko commented on YUNIKORN-1787:
----------------------------------------

We'd only avoid calling the predicates in the same cycle, inside 
{{Application.tryNodes()}}. In very tiny time interval, we might call the same 
predicate twice (yes, things can happen between the two, but this can occur in 
the current code as well - node looks good for a target, then suddenly it gets 
tainted or sth else happens and eventually it gets rejected by the kubelet). I 
definitely don't want to re-use it between multiple cycles, different method 
calls, etc.

> Re-use predicate results for reservation
> ----------------------------------------
>
>                 Key: YUNIKORN-1787
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1787
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>          Components: core - scheduler, shim - kubernetes
>            Reporter: Peter Bacsko
>            Assignee: Peter Bacsko
>            Priority: Major
>
> As mentioned in 
> https://issues.apache.org/jira/browse/YUNIKORN-1378?focusedCommentId=17720232&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17720232,
>  we don't need to run predicates again for reservation.
> If the cluster is busy and no suitable node were found for the request, we 
> check if the predicate that failed is a reservation predicate. If it is, then 
> there's no reason to run the reservation predicates.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to