[
https://issues.apache.org/jira/browse/YUNIKORN-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776495#comment-17776495
]
Wilfred Spiegelenburg commented on YUNIKORN-1987:
-------------------------------------------------
Not sure why we would need to distinguish between the not set and the null
value for a variable in go. The only integer field in the config is for
MaxApplications. MaxApplications can never be set to 0 as that would prevent
any application from starting in that queue or for that limit.
We would need to change to pointers to be able to detect that difference which
is a lot of overhead for a single field.
Please add more detail if my analysis is incorrect.
> Identity config fields not set explicitly
> -----------------------------------------
>
> Key: YUNIKORN-1987
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1987
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: core - scheduler
> Reporter: Manikandan R
> Assignee: JiaSheng Chen
> Priority: Major
> Labels: pull-request-available
>
> Need to find a way to detect fields in any config derived through
> unmarshalling yaml content to differentiate the default values from the
> values set explicitly by users.
> For example, a int field in config. By default, zero is assigned as part of
> the unmarshalling process. There could be a validation in place to throw in
> case of zero value. So, we need to identify whether user has set it
> explicitly or default value.
> In short, need to find a way to know whether field has been set or not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
