This is an automated email from the ASF dual-hosted git repository.
ccondit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/yunikorn-k8shim.git
The following commit(s) were added to refs/heads/master by this push:
new b1e44a59 [YUNIKORN-2091] Remove last remnants of Application CRD (#710)
b1e44a59 is described below
commit b1e44a59a809d6775705652e4bdf80219df2b969
Author: Craig Condit <[email protected]>
AuthorDate: Mon Oct 30 20:37:35 2023 -0500
[YUNIKORN-2091] Remove last remnants of Application CRD (#710)
Closes: #710
---
deployments/scheduler/yunikorn-rbac.yaml | 3 ---
pkg/appmgmt/interfaces/appmgr.go | 4 +---
pkg/common/constants/constants.go | 3 ---
3 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/deployments/scheduler/yunikorn-rbac.yaml
b/deployments/scheduler/yunikorn-rbac.yaml
index ff922e06..cc9cf0fa 100644
--- a/deployments/scheduler/yunikorn-rbac.yaml
+++ b/deployments/scheduler/yunikorn-rbac.yaml
@@ -38,9 +38,6 @@ rules:
- apiGroups: [""]
resources: ["pods"]
verbs: ["get", "watch", "list", "create", "patch", "update", "delete"]
- - apiGroups: ["yunikorn.apache.org"]
- resources: ["*"]
- verbs: ["*"]
- apiGroups: ["sparkoperator.k8s.io"]
resources: ["*"]
verbs: ["*"]
diff --git a/pkg/appmgmt/interfaces/appmgr.go b/pkg/appmgmt/interfaces/appmgr.go
index 4ffcc884..c55a1f8a 100644
--- a/pkg/appmgmt/interfaces/appmgr.go
+++ b/pkg/appmgmt/interfaces/appmgr.go
@@ -33,9 +33,7 @@ type AppManager interface {
// this will be called before starting the service.
ServiceInit() error
- // if the service has some internal stuff to run, this is the place to
run them
- // usually if an application is defined as K8s CRD, the operator
service needs
- // to watch on these CRD events. the CRD informers can be launched here.
+ // if the service has some internal stuff to run, this is the place to
run them.
// some implementation may not need to implement this.
Start() error
diff --git a/pkg/common/constants/constants.go
b/pkg/common/constants/constants.go
index 3b2a49ad..e30256d0 100644
--- a/pkg/common/constants/constants.go
+++ b/pkg/common/constants/constants.go
@@ -64,9 +64,6 @@ const SchedulerName = "yunikorn"
// OwnerReferences
const DaemonSetType = "DaemonSet"
-// Application crd
-const AppManagerHandlerName = "yunikorn-app"
-
// Gang scheduling
const PlaceholderContainerImage = "registry.k8s.io/pause:3.7"
const PlaceholderContainerName = "pause"
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
