[
https://issues.apache.org/jira/browse/YUNIKORN-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783238#comment-17783238
]
Ted Lin edited comment on YUNIKORN-2123 at 11/6/23 2:51 PM:
------------------------------------------------------------
[~makinyemi] Thank you for working on this.
I think your example makes sense.
This is what I'm thinking so far:
For others, find the corresponding objects of dao:
like assertGroupNameExists corresponds to GroupResourceUsageDAOInfo
So the message might be this:
{code:java}
failed to unmarshal GroupResourceUsage dao response from response body{code}
Or maybe we can do this directly:
{code:java}
failed to unmarshal GroupResourceUsageDAOInfo response from response body{code}
was (Author: steinsgateted):
[~makinyemi] Thank you for working on this.
I think your example makes sense.
This is what I'm thinking so far:
For others, find the corresponding objects of dao:
like assertGroupNameExists corresponds to GroupResourceUsageDAOInfo
So the message might be this:
{code:java}
failed to unmarshal GroupResourceUsage dao response from response body{code}
> Modify json.Unmarshal error message
> -----------------------------------
>
> Key: YUNIKORN-2123
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2123
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: core - common
> Reporter: Ted Lin
> Assignee: Michael Akinyemi
> Priority: Major
> Labels: newbie
>
> [https://github.com/apache/yunikorn-core/blob/master/pkg/webservice/handlers_test.go#L1199-L1278]
> In this code, if json.Unmarshal error, we often see:
> {code:java}
> assert.NilError(t, err, "failed to unmarshal applications dao response from
> response body"){code}
> We can replace "applications" with the meaning suitable for the function.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
