[ 
https://issues.apache.org/jira/browse/YUNIKORN-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784398#comment-17784398
 ] 

JiaChi Wang commented on YUNIKORN-2137:
---------------------------------------

Hi [~yangpoan] can I take this issue? Thanks!

> Remove defer cleanup in checkLimits
> -----------------------------------
>
>                 Key: YUNIKORN-2137
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2137
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: core - scheduler
>            Reporter: PoAn Yang
>            Assignee: PoAn Yang
>            Priority: Minor
>              Labels: newbie
>
> Code Reference: 
> [https://github.com/apache/yunikorn-core/blob/30e69f97585bc3a82f4b9c54f4cc4b601120a776/pkg/common/configs/configvalidator.go#L586-L594]
> Slack Reference: 
> [https://yunikornworkspace.slack.com/archives/CL9CRJ1KM/p1699430436233019]
>  
> The {{existedUserName}} and {{existedGroupName}} in {{checkLimits}} will be 
> GC after the goroutine leaves the function. It's safe to remove the defer 
> function.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to