[
https://issues.apache.org/jira/browse/YUNIKORN-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785248#comment-17785248
]
Vinayak Hegde commented on YUNIKORN-2089:
-----------------------------------------
Hi [~wilfreds] ,
I have a small doubt. Currently, I am trying to write a unit test for the
AggregateUsedResource(...) function, but I am facing some difficulty in
composing the expected output part. This is because AggregateUsedResource(...)
modifies the UsedResource based on time.Now(), which I cannot predict either
before or after.
So, what should we do in this situation? Or am I overlooking something basic
here?
> Move usedResource type and tests to their own files
> ---------------------------------------------------
>
> Key: YUNIKORN-2089
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2089
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: core - common
> Reporter: Wilfred Spiegelenburg
> Assignee: Vinayak Hegde
> Priority: Major
> Labels: newbie
>
> The UsedResource type should not be part of the resources.go file.
> All declarations and functions that have a UsedResource as receiver or return
> value value should be moved. Unused functions should be removed.
> Unneeded exports on functions / types should be removed. If exported the
> comments on the functions and types need to comply with standard go rules.
> All remaining functions should get tests to make sure they are working
> correctly
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
