This is an automated email from the ASF dual-hosted git repository.
pbacsko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/yunikorn-core.git
The following commit(s) were added to refs/heads/master by this push:
new 316cae15 [YUNIKORN-2126] Fixing gocritic lint issues (#703)
316cae15 is described below
commit 316cae155cd3c00a33fc7db13914aa1ba08ad4e1
Author: Michael Akinyemi <[email protected]>
AuthorDate: Mon Nov 13 17:08:17 2023 +0100
[YUNIKORN-2126] Fixing gocritic lint issues (#703)
Closes: #703
Signed-off-by: Peter Bacsko <[email protected]>
---
cmd/schedulerclient/client.go | 15 ++++++++++-----
pkg/scheduler/placement/rule.go | 2 +-
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/cmd/schedulerclient/client.go b/cmd/schedulerclient/client.go
index 0fbf773e..7e9f085a 100644
--- a/cmd/schedulerclient/client.go
+++ b/cmd/schedulerclient/client.go
@@ -20,6 +20,7 @@ package main
import (
"context"
+ "fmt"
"io"
"log"
"time"
@@ -35,6 +36,12 @@ const (
)
func main() {
+ if err := runApp(); err != nil {
+ log.Fatalf("error: %v", err)
+ }
+}
+
+func runApp() error {
// Set up a connection to the server.
conn, err := grpc.Dial(address,
grpc.WithTransportCredentials(insecure.NewCredentials()))
if err != nil {
@@ -47,13 +54,13 @@ func main() {
defer cancel()
_, err = c.RegisterResourceManager(ctx,
&si.RegisterResourceManagerRequest{})
if err != nil {
- log.Fatalf("could not greet: %v", err)
+ return fmt.Errorf("could not greet: %v", err)
}
log.Printf("Responded")
stream, err := c.UpdateAllocation(ctx)
if err != nil {
- log.Fatalf("error on update: %v", err)
+ return fmt.Errorf("error on update: %v", err)
}
done := make(chan bool)
@@ -69,9 +76,6 @@ func main() {
log.Print("Send request")
time.Sleep(time.Millisecond * 100)
}
- //if err := stream.CloseSend(); err != nil {
- // log.Println(err)
- //}
}()
// second goroutine receives data from stream
@@ -104,4 +108,5 @@ func main() {
<-done
log.Printf("Finished")
+ return nil
}
diff --git a/pkg/scheduler/placement/rule.go b/pkg/scheduler/placement/rule.go
index 94a04b45..84e1d31a 100644
--- a/pkg/scheduler/placement/rule.go
+++ b/pkg/scheduler/placement/rule.go
@@ -121,5 +121,5 @@ func normalise(name string) string {
// Replace all dots in the generated queue name before making it a fully
qualified name.
func replaceDot(name string) string {
- return strings.Replace(name, configs.DOT, configs.DotReplace, -1)
+ return strings.ReplaceAll(name, configs.DOT, configs.DotReplace)
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
