[
https://issues.apache.org/jira/browse/YUNIKORN-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YUNIKORN-2089:
-----------------------------------
Description:
The UsedResource type should not be part of the resources.go file.
All declarations and functions that have a UsedResource as receiver or return
value value should be moved. Unused functions should be removed.
Unneeded exports on functions / types should be removed. If exported the
comments on the functions and types need to comply with standard go rules.
All remaining functions should get tests to make sure they are working
correctly.
Additionally, implement Stringer interface so that zap.Any() calls can be
replaced with zap.Stringer() to avoid reflection.
was:
The UsedResource type should not be part of the resources.go file.
All declarations and functions that have a UsedResource as receiver or return
value value should be moved. Unused functions should be removed.
Unneeded exports on functions / types should be removed. If exported the
comments on the functions and types need to comply with standard go rules.
All remaining functions should get tests to make sure they are working
correctly.
Additionally, implement String() function so that zap.Any() calls can be
replaced with zap.Stringer() to avoid reflection.
> Move usedResource type and tests to their own files
> ---------------------------------------------------
>
> Key: YUNIKORN-2089
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2089
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: core - common
> Reporter: Wilfred Spiegelenburg
> Assignee: Vinayak Hegde
> Priority: Major
> Labels: newbie, pull-request-available
>
> The UsedResource type should not be part of the resources.go file.
> All declarations and functions that have a UsedResource as receiver or return
> value value should be moved. Unused functions should be removed.
> Unneeded exports on functions / types should be removed. If exported the
> comments on the functions and types need to comply with standard go rules.
> All remaining functions should get tests to make sure they are working
> correctly.
> Additionally, implement Stringer interface so that zap.Any() calls can be
> replaced with zap.Stringer() to avoid reflection.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
