[
https://issues.apache.org/jira/browse/YUNIKORN-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786432#comment-17786432
]
Peter Bacsko edited comment on YUNIKORN-2135 at 11/15/23 5:06 PM:
------------------------------------------------------------------
Well the one thing which is important is how we retrieve the coverage data, how
it is generated. I suppose it's still a text file which is available as soon as
the process exits. So we need a way to access&retrieve it properly. My approach
was using PV, that is, having a mount point. The coverage file was written to
that mount point.
We can also have a different entry point other than the YK binary: a script
which starts the binary in a loop, so from the perspective from K8s, the
container keeps running. For example, we start netcat listening on a specific
port. If we receive anything, then we kill yunikorn and restart it. After that,
we fetch the generated file from inside the Yunikorn container.
was (Author: pbacsko):
Well the one thing which is important is how we retrieve the coverage data, how
it is generated. I suppose it's still a text file which is available as soon as
the process exits. So we need a way to access&retrieve it properly. My approach
was using PV, that is, having a mount point. The covewrage file was written to
that mount point.
We can also have a different entry point other than the YK binary: a script
which starts the binary in a loop, so from the perspective from K8s, the
container keeps running. For example, we start netcat listening on a specific
port. If we receive anything, then we kill yunikorn and restart it. After that,
we fetch the generated file from inside the Yunikorn container.
> Add integration test code coverage
> ----------------------------------
>
> Key: YUNIKORN-2135
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2135
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: test - e2e
> Reporter: PoAn Yang
> Assignee: PoAn Yang
> Priority: Major
>
> From [https://go.dev/testing/coverage/]:
> > Beginning in Go 1.20, Go supports collection of coverage profiles from
> > applications and from integration tests, larger and more complex tests for
> > Go programs.
> We have many integration test cases with ginkgo. It's good to have a new code
> coverage with golang new feature. We can use different
> [flags|https://github.com/codecov/codecov-action#usage] to submit
> unit/integration test code coverage to codecov.
>
> Ref: [https://go.dev/blog/integration-test-coverage]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
