[
https://issues.apache.org/jira/browse/YUNIKORN-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790000#comment-17790000
]
Kuan-Po Tseng commented on YUNIKORN-2081:
-----------------------------------------
I've addressed a pull request to update karma-jasmine to version 5.1.0 and
remove the dependency on ng-bullet since it is causing an error, as indicated
in [this
link|https://github.com/topnotch48/ng-bullet-workspace/blob/4cb3b2a3bfaf0d47277dcaabe4bd76b0062ce11c/projects/ng-bullet/src/testing.ts#L23-L26].
Moreover, ng-bullet hasn't been updated for approximately 5 years. Some users
have [reported the
issue|https://github.com/topnotch48/ng-bullet-workspace/issues/38], and there
is a [pull request|https://github.com/topnotch48/ng-bullet-workspace/pull/39]
attempting to address it, but it hasn't been merged into ng-bullet yet. The
purpose of ng-bullet is to [reduce the overall test execution
time|https://github.com/topnotch48/ng-bullet-workspace/blob/master/projects/ng-bullet/README.md].
However, after removing ng-bullet, I didn't observe a significant increase in
test time (17.51s -> 18.44s).
> Update karma in web UI test
> ---------------------------
>
> Key: YUNIKORN-2081
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2081
> Project: Apache YuniKorn
> Issue Type: Task
> Components: webapp
> Reporter: Wilfred Spiegelenburg
> Assignee: Kuan-Po Tseng
> Priority: Major
> Labels: pull-request-available
>
> When trying to update karma to 5.x all the js tests fail.
> Karma 4.x logs this warning for a random suite
> {code:java}
> ERROR LOG: 'DEPRECATION: An asynchronous before/it/after function took a done
> callback but also returned a promise. This is not supported and will stop
> working in the future. Either remove the done callback (recommended) or
> change the function to not return a promise. (in suite: XXXX)
> Note: This message will be shown only once. Set the verboseDeprecations
> config property to true to see every occurrence.' {code}
> This changes to a hard failure in 5.x:
> {code:java}
> An error was thrown in afterAll
> An asynchronous before/it/after function took a done callback but also
> returned a promise. Either remove the done callback (recommended) or change
> the function to not return a promise. thrown {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
