[
https://issues.apache.org/jira/browse/YUNIKORN-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797896#comment-17797896
]
Chia-Ping Tsai commented on YUNIKORN-2275:
------------------------------------------
[~ccondit] thanks for response and happy holidays :)
I noticed this issue when testing following case. please take a look and
correct me if I'm misunderstood.
steps:
1. start yunikorn scheduler (no AM) with following ConfigMap
{code:yaml}
apiVersion: v1
kind: ConfigMap
metadata: name: yunikorn-configs
data:
service.enableConfigHotRefresh: "true"
log.level: "INFO"
queues.yaml: |
...
{code}
2. update ConfigMap to change `service.enableConfigHotRefresh` from "true" to
"false".
3. update ConfigMap to change `log.level` from INFO to DEBUG
{*}expected{*}:
the step.3 should not be applied since `service.enableConfigHotRefresh` is
"disabled"
*actual*
the log.level gets changed and it starts to show debug-level output.
---------------------------
*trace code*
[https://github.com/apache/yunikorn-k8shim/blob/master/pkg/cache/context.go#L483]
{code:go}
conf := ctx.apiProvider.GetAPIs().GetConf()
if !conf.EnableConfigHotRefresh {
log.Log(log.ShimContext).Info("hot-refresh disabled, skipping
scheduler configuration update")
return
}
{code}
the conf from `ctx.apiProvider.GetAPIs().GetConf()` is referenced to bootstrap
config, so `conf.EnableConfigHotRefresh` is always true. Also, it would not be
changed by updating ConfigMaps.
> fix the doc about service.enableConfigHotRefresh
> ------------------------------------------------
>
> Key: YUNIKORN-2275
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2275
> Project: Apache YuniKorn
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Priority: Trivial
>
> [https://yunikorn.apache.org/docs/user_guide/service_config#serviceenableconfighotrefresh]
> the docs say "A change to this setting will be picked up without a restart of
> YuniKorn.", and I feel that is incorrect since it requires scheduler to
> restart.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
