[
https://issues.apache.org/jira/browse/YUNIKORN-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797995#comment-17797995
]
Chia-Ping Tsai commented on YUNIKORN-2258:
------------------------------------------
[~wilfreds] thanks for feedback!
{quote}
It is also impossible to distinguish between a 0 and not being part of the
config with the parsing we do.
{quote}
agree
{quote}
A zero for maxapplications should be ignored as it will not be set in the
system.
So any 0 values should be ignored by the validator.
Also setting a zero does not make sense as it blocks the whole queue.
{quote}
My point was the "behavior" is not consistent between "parent" and "child". the
undefined maxapplications is equal to zero and the zero value is ignored by the
validator for "parent" only. it makes sense to me. However, child queues don't
have such sugar and hence we must define maxapplications for "all" child
queues. That is what really weird.
> align the behavior of undefined maxapplications with resources
> --------------------------------------------------------------
>
> Key: YUNIKORN-2258
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2258
> Project: Apache YuniKorn
> Issue Type: Wish
> Reporter: Chia-Ping Tsai
> Assignee: Vinayak Hegde
> Priority: Major
>
> The following config is invalid since the undefined `maxapplications` of
> child queue is considered be zero. It means all leaf queues must define
> `maxapplications` if parent has `maxapplications`.
>
> {code:java}
> partitions:
> - name: default
> queues:
> - name: root
> parent: true
> submitacl: "*"
> maxapplications: 2
> queues:
> - name: child {code}
>
>
> In contrast, the resources has no such requirements. We can leave undefined
> resources for leaf queues. For example:
>
> {code:java}
> partitions:
> - name: default
> queues:
> - name: root
> parent: true
> submitacl: "*"
> queues:
> - name: parent
> resources:
> max:
> memory: 20G
> vcore: 20
> queues:
> - name: child {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
