[
https://issues.apache.org/jira/browse/YUNIKORN-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800803#comment-17800803
]
Peter Bacsko edited comment on YUNIKORN-1978 at 12/27/23 3:04 PM:
------------------------------------------------------------------
Just a question... I just reviewed this test, but do we really need want to
test this on e2e level? It feels unnecessary. There's a separate
{{MockScheduler}} in the scheduler-core where this can be tested easily with
isolation.
First we need to ensure proper unit test coverage. If we have that, we can step
up to higher integration test levels, eg. the ones in {{partition_test.go}}.
Then next is {{MockScheduler}} with the core. Then {{MockScheduler}} with
k8shim+core. This should be the way to go. In general, I think we skip the
integration and move to e2e too quickly. It's a general problem, something that
needs to be discussed IMO.
was (Author: pbacsko):
Just a question... I just reviewed this test, but do we really need want to
test this on e2e level? It feels unnecessary. There's a separate
{{MockScheduler}} in the scheduler-core where this can be tested easily with
isolation.
First we need to ensure proper unit test coverage. If we have that, we can step
up to higher integration test levels, eg. the ones in {{partition_test.go}}.
Then next is {{MockScheduler}} with the core. Then {{MockScheduler}} with
k8shim+core. This should be the way to go. In general, I think we skip the
integration level too quickly and move to e2e too quickly, it's a general
problem, something that needs to be discussed IMO.
> Add e2e test for node sorting with the fairness policy
> ------------------------------------------------------
>
> Key: YUNIKORN-1978
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1978
> Project: Apache YuniKorn
> Issue Type: Test
> Components: test - e2e
> Reporter: Hsuan Zong Wu
> Assignee: Hsuan Zong Wu
> Priority: Minor
> Labels: pull-request-available
>
> Currently, there are no test cases for Node sorting under the Fairness
> policy.
> As a result, we should create test cases for both the base case and the case
> with resource weights added.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
