[
https://issues.apache.org/jira/browse/YUNIKORN-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812320#comment-17812320
]
Chia-Ping Tsai commented on YUNIKORN-2335:
------------------------------------------
[~Geordie] could you please check k8shim repo also? for example:
[https://github.com/apache/yunikorn-k8shim/blob/master/pkg/log/logger.go#L269]
> Use go standard library min and max functions
> ---------------------------------------------
>
> Key: YUNIKORN-2335
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2335
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: core - common
> Reporter: Wilfred Spiegelenburg
> Assignee: GeordieMai
> Priority: Major
> Labels: newbie, pull-request-available
>
> Go 1.21 introduced standard min and max builtin functions.
> We should remove the following functions:
> * MaxQuantity (resources)
> * MinQuantity (resources)
> * min (ring buffer)
> * Min (common utils)
> Replace with min and max builtin functions.
> NOTE: this requires a go directive change in the go.mod file to move to 1.21
> as the minimum version. This needs to be coordinates for the different repos.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
