[
https://issues.apache.org/jira/browse/YUNIKORN-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813429#comment-17813429
]
Wilfred Spiegelenburg commented on YUNIKORN-2375:
-------------------------------------------------
Currently we register a dummy plugin for the state dump on init of the code.
This is contrary to what we do for the normal callback plugin. For the normal
plugin we expect that we can have a nil returned when retrieved. We should do
the same for the state dump plugin. That removes the dummy plugin we currently
have.
Will log a new Jira for that to not mix the two issue.
> Move mocks to a central place
> -----------------------------
>
> Key: YUNIKORN-2375
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2375
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: core - common
> Reporter: Wilfred Spiegelenburg
> Assignee: Wilfred Spiegelenburg
> Priority: Major
>
> The ResourceManagerCallback API implementations are in a large number of
> places for tests. The base implementation that is used often resides in
> {{scheduler/tests}} this requires packages outside the scheduler to import
> that one.
> There is no need for that and it could even cause circular references on
> imports. Moving the base implementation and all mocks that we need into a top
> level package would simplify the code
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
