This is an automated email from the ASF dual-hosted git repository.
ccondit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/yunikorn-core.git
The following commit(s) were added to refs/heads/master by this push:
new a87a4630 [YUNIKORN-2406] Ensure shim is notified of existing
allocations being added (#801)
a87a4630 is described below
commit a87a46308189209c0440f9b8be59ba39637c93fc
Author: Craig Condit <[email protected]>
AuthorDate: Wed Feb 14 08:37:06 2024 -0600
[YUNIKORN-2406] Ensure shim is notified of existing allocations being added
(#801)
When existing allocations are registered from the shim to the core, they are
added to the partition, but the shim is never notified that the allocations
were successfully registered. This manifests in the core as missing history
for container allocations, and in the shim by tasks not transitioning to a
bound state.
Closes: #801
---
go.mod | 2 +-
go.sum | 4 ++--
pkg/scheduler/context.go | 2 ++
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/go.mod b/go.mod
index 54b5b878..68e2315d 100644
--- a/go.mod
+++ b/go.mod
@@ -22,7 +22,7 @@ module github.com/apache/yunikorn-core
go 1.21
require (
- github.com/apache/yunikorn-scheduler-interface
v0.0.0-20231211235204-ec7bfad7d00e
+ github.com/apache/yunikorn-scheduler-interface
v0.0.0-20240213122907-834ff5c1f36c
github.com/google/btree v1.1.2
github.com/google/go-cmp v0.6.0
github.com/google/uuid v1.6.0
diff --git a/go.sum b/go.sum
index 0c356874..9a302e55 100644
--- a/go.sum
+++ b/go.sum
@@ -1,7 +1,7 @@
github.com/HdrHistogram/hdrhistogram-go v1.0.1
h1:GX8GAYDuhlFQnI2fRDHQhTlkHMz8bEn0jTI6LJU0mpw=
github.com/HdrHistogram/hdrhistogram-go v1.0.1/go.mod
h1:BWJ+nMSHY3L41Zj7CA3uXnloDp7xxV0YvstAE7nKTaM=
-github.com/apache/yunikorn-scheduler-interface
v0.0.0-20231211235204-ec7bfad7d00e
h1:WiDns+JSNrp1jUfTkwtTwVyfxAhe3vPMtxJxs2CRseE=
-github.com/apache/yunikorn-scheduler-interface
v0.0.0-20231211235204-ec7bfad7d00e/go.mod
h1:zDWV5y9Zh9DM1C65RCVXT1nhNNO8kykVW7bzPFamNYw=
+github.com/apache/yunikorn-scheduler-interface
v0.0.0-20240213122907-834ff5c1f36c
h1:u4ckUfYqKfrRGUyvGcyS5lMu1eVOsiMQZafjCcE/tNw=
+github.com/apache/yunikorn-scheduler-interface
v0.0.0-20240213122907-834ff5c1f36c/go.mod
h1:Ga7qJusiW9E/dRokVGB50sUycR9Oc/yooixJWS0K7ZY=
github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
github.com/beorn7/perks v1.0.1/go.mod
h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=
github.com/cespare/xxhash/v2 v2.2.0
h1:DC2CZ1Ep5Y4k3ZQ899DldepgrayRUGE6BBZ/cd9Cj44=
diff --git a/pkg/scheduler/context.go b/pkg/scheduler/context.go
index c30a811d..1a71b600 100644
--- a/pkg/scheduler/context.go
+++ b/pkg/scheduler/context.go
@@ -788,7 +788,9 @@ func (cc *ClusterContext) processAllocations(request
*si.AllocationRequest) {
zap.String("applicationID",
siAlloc.ApplicationID),
zap.String("allocationKey",
siAlloc.AllocationKey),
zap.Error(err))
+ continue
}
+ cc.notifyRMNewAllocation(request.RmID, alloc)
}
// Reject allocs returned to RM proxy for the apps and partitions not
found
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
