[
https://issues.apache.org/jira/browse/YUNIKORN-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818053#comment-17818053
]
Yu-Lin Chen commented on YUNIKORN-2395:
---------------------------------------
Hi [~wilfreds], [~chia7712],
After conducting some studies on deprecating Jaeger, I think it’s better to
cleanup pkg/traces instead of replacing Jaeger. Below are my reasons:
# The Jaeger related code was introduced after YUNIKORN-444 and
{color:#de350b}has not been referenced{color} in core for 3 years.
# Changing to OpenTelemetry would require us to replace all the OpenTracing
api and re-implement SchedulerTraceContext interface in
[scheduler_trace_context.go|https://github.com/apache/yunikorn-core/blob/master/pkg/trace/scheduler_trace_context.go#L42].
(Also need to design how to initialize TraceProviders) These changes would
almost rewrite the entire pkg/trace, I believe removing it and re-implement it
with OpenTelemetry is better than deprecating Jaeger.
# After YUNIKORN-1628 [Umbrella] YuniKorn application traceability, we have
basic tracebility for tracing applications in core. Although OpenTelemetry is a
standard for telemetry applications, we should reconsider if there is a real
use case to keep going with YUNIKORN-444.
Base on the above reasons, I’ll change this Jira to YUNIKORN-387’s sub-task and
remove code in pkg/trace. Also rename this Jira to "Remove Jaeger dependencies
and cleanup outdate traces implementation."
Please let me know if there have any concerns.
> Replace deprecated jaeger-client-go
> -----------------------------------
>
> Key: YUNIKORN-2395
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2395
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: core - common
> Reporter: Wilfred Spiegelenburg
> Assignee: Yu-Lin Chen
> Priority: Minor
>
> The library has been deprecated for almost 2 years now and we should no
> longer use this in our code.
> We are also not using the latest version and should directly migrate to
> OpenTelemetry as per the [notice in the
> documentation.|https://www.jaegertracing.io/docs/latest/client-libraries/#deprecating-jaeger-clients]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
