This is an automated email from the ASF dual-hosted git repository.
pbacsko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/yunikorn-core.git
The following commit(s) were added to refs/heads/master by this push:
new 9e778f44 [YUNIKORN-2427] Use r-lock instead of rw-lock in
user_tracker.go#getGroupForApp (#807)
9e778f44 is described below
commit 9e778f447057ae0799bf8cbbce39c8b49d0a2961
Author: Yu-Lin Chen <[email protected]>
AuthorDate: Wed Feb 21 11:34:43 2024 +0100
[YUNIKORN-2427] Use r-lock instead of rw-lock in
user_tracker.go#getGroupForApp (#807)
Closes: #807
Signed-off-by: Peter Bacsko <[email protected]>
---
pkg/scheduler/ugm/group_tracker.go | 4 ++--
pkg/scheduler/ugm/user_tracker.go | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/pkg/scheduler/ugm/group_tracker.go
b/pkg/scheduler/ugm/group_tracker.go
index 85cdd30e..255eeafa 100644
--- a/pkg/scheduler/ugm/group_tracker.go
+++ b/pkg/scheduler/ugm/group_tracker.go
@@ -111,8 +111,8 @@ func (gt *GroupTracker) IsUnlinkRequired(hierarchy
[]string) bool {
}
func (gt *GroupTracker) UnlinkQT(hierarchy []string) bool {
- gt.RLock()
- defer gt.RUnlock()
+ gt.Lock()
+ defer gt.Unlock()
return gt.queueTracker.UnlinkQT(hierarchy)
}
diff --git a/pkg/scheduler/ugm/user_tracker.go
b/pkg/scheduler/ugm/user_tracker.go
index 97a4a60e..b93b5396 100644
--- a/pkg/scheduler/ugm/user_tracker.go
+++ b/pkg/scheduler/ugm/user_tracker.go
@@ -101,8 +101,8 @@ func (ut *UserTracker) setGroupForApp(applicationID string,
groupTrack *GroupTra
}
func (ut *UserTracker) getGroupForApp(applicationID string) string {
- ut.Lock()
- defer ut.Unlock()
+ ut.RLock()
+ defer ut.RUnlock()
if ut.appGroupTrackers[applicationID] != nil {
return ut.appGroupTrackers[applicationID].groupName
}
@@ -156,8 +156,8 @@ func (ut *UserTracker) IsUnlinkRequired(hierarchy []string)
bool {
}
func (ut *UserTracker) UnlinkQT(hierarchy []string) bool {
- ut.RLock()
- defer ut.RUnlock()
+ ut.Lock()
+ defer ut.Unlock()
return ut.queueTracker.UnlinkQT(hierarchy)
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
