[
https://issues.apache.org/jira/browse/YUNIKORN-2475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825491#comment-17825491
]
Wilfred Spiegelenburg commented on YUNIKORN-2475:
-------------------------------------------------
All in favour of option 1: update our code base. The helper method adds extra
overhead we do not need/want. We still would need to convert the K8s resource
that gets generated into the SI based resource, again more overhead.
> Add support for K8s native sidecars (restartable init containers)
> -----------------------------------------------------------------
>
> Key: YUNIKORN-2475
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2475
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Major
>
> K8s v1.28 added support for [native
> sidecars|https://kubernetes.io/blog/2023/08/25/native-sidecar-containers/].
> This introduces restartable init containers, ie. init containers that keep
> running along with the main ones.
> The changes resource request calculations. A [helper
> method|https://github.com/kubernetes/kubernetes/blob/c73ab5162b43356414908d7260fea29af6d4be1e/pkg/api/v1/resource/helpers.go#L50)]
> in the K8s codebase is available for resource calculations. However, this
> seems to be too complicated and inefficient.
> Our options are:
> 1. Change our [existing
> code|https://github.com/apache/yunikorn-k8shim/blob/3327a6806b30d8c857b3516916491c86f5954f87/pkg/common/resource.go#L54]
> in the shim and update our unit tests.
> 2. Re-use the {{GetPodResources()}} function from K8s.
> If we keep our own code, I recommend that we create unit tests that perform
> comparisons between the two.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
