[
https://issues.apache.org/jira/browse/YUNIKORN-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825902#comment-17825902
]
Wilfred Spiegelenburg commented on YUNIKORN-2466:
-------------------------------------------------
To clarify what [~chia7712] is pointing at in a couple of places we call
{{git}} without checks. The one place that we do have this check is for the
build date resolution.
We do not have it in a number of other targets:
* SHIM_SHA: this variable gets replaced with a hard coded SHA in the release
Makefile
* lint: not relevant in release bundle target should not be used as the result
would show old results when you run it without SHA
* pseudo: test for pseudo ref only in master, not needed in release code as
the refs are not used. We use a hard replace to build just from the tarball.
> Eliminate all git error from Makefile
> -------------------------------------
>
> Key: YUNIKORN-2466
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2466
> Project: Apache YuniKorn
> Issue Type: Bug
> Reporter: Chia-Ping Tsai
> Priority: Minor
>
> I encounter the git error when testing 1.5.0 RC1 code. The root cause is that
> there is no git folder in the release code. It seems to me running the tests
> (and other make action) for release source code is necessary and the git
> error should disappear.
> We can use if-else (e.x `if [ -d "$(BASE_DIR)/.git" ]`) to eliminate the git
> error.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
