[
https://issues.apache.org/jira/browse/YUNIKORN-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827321#comment-17827321
]
amikai commented on YUNIKORN-2474:
----------------------------------
At point 1, the origins and context of the UpdateConfigMapWrapper and
RestoreConfigMapWrapper functions are still under discussion, See discussion in
[PR|https://github.com/apache/yunikorn-k8shim/pull/800].
So, I'll create another ticket
[2492|https://issues.apache.org/jira/browse/YUNIKORN-2492] to continue working
on point 2.
> Unused variable and methods
> ---------------------------
>
> Key: YUNIKORN-2474
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2474
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: test - e2e
> Reporter: Kuan Po Tseng
> Assignee: amikai
> Priority: Trivial
> Labels: pull-request-available
>
> # These two methods UpdateConfigMapWrapper and RestoreConfigMapWrapper under
> test/e2e/wrappers.go are unused.
> [https://github.com/apache/yunikorn-k8shim/blob/ebcb25ba8c19b772b5026b5c82b7e27a449b86df/test/e2e/wrappers.go#L39-L92]
> # Besides that the function parameter `annotation string` in
> UpdateCustomConfigMapWrapperWithMap and RestoreConfigMapWrapper are unused in
> test/e2e/framework/helpers/yunikorn/wrappers.go
> [https://github.com/apache/yunikorn-k8shim/blob/ebcb25ba8c19b772b5026b5c82b7e27a449b86df/test/e2e/framework/helpers/yunikorn/wrappers.go#L76C90-L76C100|https://github.com/apache/yunikorn-k8shim/blob/ebcb25ba8c19b772b5026b5c82b7e27a449b86df/test/e2e/framework/helpers/yunikorn/wrappers.go#L76]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
