[ 
https://issues.apache.org/jira/browse/YUNIKORN-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Bacsko updated YUNIKORN-2547:
-----------------------------------
    Description: 
We found two issues when adding an application to a queue:
# Inside {{Queue.AddApplication()}}, we parse and process "quota" and 
"guaranteed" from the application tags, then we set them on the queue if they 
have a valid value. We shouldn't be doing this inside {{AddApplication()}}, but 
rather when we're constructing the application object. That way, they're 
already available when the app is being added.
# We an add application to the Queue, but this can be reverted immediately if 
the placeholder doesn't fit or the "sortType" is not FIFO.

  was:
Inside {{Queue.AddApplication()}}, we parse and process "quota" and 
"guaranteed" from the application tags, then we set them on the queue if they 
have a valid value.

We shouldn't be doing this inside {{AddApplication()}}, but rather when we're 
constructing the application object. That way, they're already available when 
the app is being added.


> Queue: clean up logic when adding application
> ---------------------------------------------
>
>                 Key: YUNIKORN-2547
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2547
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>          Components: core - scheduler
>            Reporter: Peter Bacsko
>            Assignee: Peter Bacsko
>            Priority: Major
>
> We found two issues when adding an application to a queue:
> # Inside {{Queue.AddApplication()}}, we parse and process "quota" and 
> "guaranteed" from the application tags, then we set them on the queue if they 
> have a valid value. We shouldn't be doing this inside {{AddApplication()}}, 
> but rather when we're constructing the application object. That way, they're 
> already available when the app is being added.
> # We an add application to the Queue, but this can be reverted immediately if 
> the placeholder doesn't fit or the "sortType" is not FIFO.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to