[
https://issues.apache.org/jira/browse/YUNIKORN-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
JiaChi Wang reassigned YUNIKORN-2299:
-------------------------------------
Assignee: JiaChi Wang
> parse `application.stateaware.disable` by strconv.ParseBool
> -----------------------------------------------------------
>
> Key: YUNIKORN-2299
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2299
> Project: Apache YuniKorn
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Assignee: JiaChi Wang
> Priority: Trivial
>
> [https://github.com/apache/yunikorn-core/blob/master/pkg/scheduler/objects/application.go#L180]
> {code:go}
> if app.GetTag(siCommon.AppTagStateAwareDisable) != "" {
> app.startTimeout = 0 // transition immediately to Running
> } else {
> app.startTimeout = startingTimeout
> }
> {code}
> the code does not check the boolean value, and it seems to me that is
> error-prone. It would be better to use `strconv.ParseBool` to check actual
> boolean value.
> BTW, the first commit
> ([https://github.com/apache/yunikorn-k8shim/commit/7ef00345151848a82708dc7b6eec9b473e14d325])
> of `application.stateaware.disable` used the value "true" and the later
> commits did not change the value, so it wouldn't break the compatibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
