[ 
https://issues.apache.org/jira/browse/YUNIKORN-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hsien-Cheng(Ryan) Huang updated YUNIKORN-2482:
----------------------------------------------
    Description: 
The update of setting a template on a parent could fail if the template is not 
correct. The error is swallowed and a success is returned but the update of the 
queue has not finished correctly:
*Queue.applyConf()
{code:go}
if !sq.isLeaf {
    if err = sq.setTemplate(conf.ChildTemplate); err != nil {
       return nil
    }
} 
==={code}
Need to add tests to make sure we do not regress.

  was:
The update of setting a template on a parent could fail if the template is not 
correct. The error is swallowed and a success is returned but the update of the 
queue has not finished correctly:
*Queue.applyConf()
{code:java}
if !sq.isLeaf {
    if err = sq.setTemplate(conf.ChildTemplate); err != nil {
       return nil
    }
} {code}
Need to add tests to make sure we do not regress.


> Failure to set template does not return error
> ---------------------------------------------
>
>                 Key: YUNIKORN-2482
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2482
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: core - scheduler
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Hsien-Cheng(Ryan) Huang
>            Priority: Major
>              Labels: newbie, pull-request-available
>
> The update of setting a template on a parent could fail if the template is 
> not correct. The error is swallowed and a success is returned but the update 
> of the queue has not finished correctly:
> *Queue.applyConf()
> {code:go}
> if !sq.isLeaf {
>     if err = sq.setTemplate(conf.ChildTemplate); err != nil {
>        return nil
>     }
> } 
> ==={code}
> Need to add tests to make sure we do not regress.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to