[
https://issues.apache.org/jira/browse/YUNIKORN-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840291#comment-17840291
]
Kuan Cheng Lung commented on YUNIKORN-2582:
-------------------------------------------
ok
> Shim: Use atomic.Int32 for atomic operations
> --------------------------------------------
>
> Key: YUNIKORN-2582
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2582
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes
> Reporter: Yu-Lin Chen
> Priority: Major
> Labels: newbie
>
> Type atomic.Int32 was introduced in go 1.19, we should adopt it for better
> code clarity.
> Below variable type should be changed:
> 1. asyncDispatchCount in
> [dispatcher.go|https://github.com/apache/yunikorn-k8shim/blob/299816338caa1053e76e8f0d627321335d159cd2/pkg/dispatcher/dispatcher.go#L50]
> 2. registerCount/UpdateAllocationCount/UpdateApplicationCount/UpdateNodeCount
> in
> [schedulerapi_mock.go|https://github.com/apache/yunikorn-k8shim/blob/299816338caa1053e76e8f0d627321335d159cd2/pkg/common/test/schedulerapi_mock.go#L30-L33]
>
> PS: This Jira is based on the discussion under YUNIKORN-2576.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
