[
https://issues.apache.org/jira/browse/YUNIKORN-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841875#comment-17841875
]
Wilfred Spiegelenburg commented on YUNIKORN-2593:
-------------------------------------------------
We need to be careful here. This now forces a unique partition to be specified
by all shims that register. If that is not the case we break. One shim would
overwrite the partition setup of a second shim. The first part of the "full"
partition name is the hostname and port of the shim that registers the
partition allowing remote shims to be identified.
If you are going to do this we might as well drop the whole multi & remote shim
and multi partition design. Which would mean moving to one repository removing
the SI etc along the way. I don't think that is a good idea.
What I do not understand is why do we have partition anywhere in the scheduler
objects? With objects I refer to anything like application, ask or node etc.
Those cannot belong to anything but one partition and are only referenced from
that one partition. They should not have the partition details as part of the
object. It is redundant information taking up memory.
A simple remove of the partition name from all these objects should suffice.
BTW: The webservice broke the whole remote and multi shim idea when it was
setup and we never got around to fixing that. We do not want to break it
further.
> Simplify partition name
> -----------------------
>
> Key: YUNIKORN-2593
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2593
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: core - scheduler
> Reporter: Craig Condit
> Assignee: Craig Condit
> Priority: Major
> Labels: pull-request-available
>
> Currently, partition names are treated differently in different places within
> the core. Specifically, sometimes they are bare (i.e. "default") and other
> places they are composite (i.e. "[rm:123]default"). This is confusing and
> unnecessary. It also hampers efforts to merge the AllocationAsk and
> Allocation objects, as the semantics are different between them. Switch to
> using bare form ("default") everywhere instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
