[
https://issues.apache.org/jira/browse/YUNIKORN-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848269#comment-17848269
]
Chia-Ping Tsai commented on YUNIKORN-2637:
------------------------------------------
{quote}
The pod may have moved into a terminal state between registerPods() and
finalizePods().
{quote}
Do you mean those pods is possible be moved into terminal state "before" we add
an event handler? In that scenario, they are not handled by event handler, and
they will become phantom pods if we don't call `ctx.DeletePod(pod)` in
`finalizePods`.
> finalizePods should ignore pods like registerPods does
> ------------------------------------------------------
>
> Key: YUNIKORN-2637
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2637
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: shim - kubernetes
> Reporter: Wilfred Spiegelenburg
> Priority: Major
>
> The initialisation code is a two step process for pods: first list all pods
> and add them to the system in registerPods(). This returns a list of pods
> processed.
> The second step happens after event handlers are turned on and nodes have
> been cleaned up etc. During the second step pods from the first step are
> checked and removed. However pods that were already in a terminated state in
> step 1 get removed again. Although the step should be idempotent this is
> unneeded. When iterating over the existing pods any pod in a terminal state
> should be skipped.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
