[
https://issues.apache.org/jira/browse/YUNIKORN-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850896#comment-17850896
]
Wilfred Spiegelenburg commented on YUNIKORN-182:
------------------------------------------------
File a new Jira for this, it needs to be fixed in all our http servers we
create in our code, those are spread over multiple repositories and all need to
be checked:
{code:java}
pkg/cmd/admissioncontroller/main.go:143:15: G112: Potential Slowloris Attack
because ReadHeaderTimeout is not configured in the http.Server (gosec) {code}
This one should get an ignore from the lint side, we do not need crypt quality
random here;
{code:java}
test/e2e/framework/helpers/common/utils.go:105:18: G404: Use of weak random
number generator (math/rand instead of crypto/rand) (gosec)
b[i] = letters[rand.Intn(len(letters))]{code}
All the ineffective assigns and shadowing remarks can and should be fixed.
Formatting issues can snd should be fixed
The function length ones are dubious and we probably should just add the
{{//nolint:funlen}} remark on them specially since they are almost all test
functions.
> fix lint issues
> ---------------
>
> Key: YUNIKORN-182
> URL: https://issues.apache.org/jira/browse/YUNIKORN-182
> Project: Apache YuniKorn
> Issue Type: Task
> Components: build
> Reporter: Wilfred Spiegelenburg
> Assignee: Yun Sun
> Priority: Minor
> Labels: pull-request-available
>
> When we added the lint test most major issues were fixed. There are still a
> lot of issues specially in tests that need to be fixed.
> This is a container Jira to track that work on both the k8shim as the core
> repos.
> Work should be split into multiple parts (per linter?)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
