[ 
https://issues.apache.org/jira/browse/YUNIKORN-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manikandan R updated YUNIKORN-2684:
-----------------------------------
    Description: 
After the hardening exercises, there are few places in preemption.go which we 
are seeing dead code, doubtful of going through any situations. Need to assess 
those places by reviewing and/or writing appropriate test cases. Below link is 
one of such places which had come through reviews:

[https://github.com/apache/yunikorn-core/pull/830#discussion_r1636755074]

In case if we find those code to be dead, it needs to be cleaned up.

  was:
There are few places in preemption.go which is doubtful of going through any 
situations. Need to assess those places by reviewing and/or writing appropriate 
test cases. Below link is one of such places which had come through reviews:

[https://github.com/apache/yunikorn-core/pull/830#discussion_r1636755074]

In case if we find those code to be dead, it needs to be cleaned up.


> Unused Code cleanup
> -------------------
>
>                 Key: YUNIKORN-2684
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2684
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>          Components: core - scheduler
>            Reporter: Manikandan R
>            Priority: Major
>
> After the hardening exercises, there are few places in preemption.go which we 
> are seeing dead code, doubtful of going through any situations. Need to 
> assess those places by reviewing and/or writing appropriate test cases. Below 
> link is one of such places which had come through reviews:
> [https://github.com/apache/yunikorn-core/pull/830#discussion_r1636755074]
> In case if we find those code to be dead, it needs to be cleaned up.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to