[
https://issues.apache.org/jira/browse/YUNIKORN-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864164#comment-17864164
]
Chia-Ping Tsai commented on YUNIKORN-2729:
------------------------------------------
{quote}
I am all for this as long as we fix all the issues. It is not good enough to
fix most. We need a clean {{make lint}} result.
{quote}
That is 100% what we want to address :)
{quote}
If we do not the pre-commit tests will fail. When the pre-commit tests fail in
the linter no unit tests are run which means no commit.
{quote}
yep, I had filed [https://github.com/apache/yunikorn-core/pull/910] to prove
it. That is good thing actually, as our pre-commit can leverage linter totally.
> remove `--new-from-rev` from Makefile
> -------------------------------------
>
> Key: YUNIKORN-2729
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2729
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Reporter: Chia-Ping Tsai
> Assignee: Huang Guan Hao
> Priority: Minor
> Labels: pull-request-available
>
> It is time to show the power of lint :)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
