[
https://issues.apache.org/jira/browse/YUNIKORN-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated YUNIKORN-2756:
-------------------------------------
Description:
All other event-related configs are in configs#const[1], so we should move
`defaultEventChannelSize`[0] make them together.
BTW, `defaultRingBufferSize`[2] will be removed by
https://github.com/apache/yunikorn-core/pull/915, since its replacement is in
configs#const already [3]
[0]
https://github.com/apache/yunikorn-core/blob/f25bee90c2abd2c6682912dfdd0013ef2f4bc0ba/pkg/events/event_system.go#L37
[1]
https://github.com/apache/yunikorn-core/blob/f25bee90c2abd2c6682912dfdd0013ef2f4bc0ba/pkg/common/configs/configs.go#L43
[2]
https://github.com/apache/yunikorn-core/blob/f25bee90c2abd2c6682912dfdd0013ef2f4bc0ba/pkg/events/event_system.go#L38
[3]
https://github.com/apache/yunikorn-core/blob/f25bee90c2abd2c6682912dfdd0013ef2f4bc0ba/pkg/common/configs/configs.go#L47
was:
All other event-related configs are in configs#const, so we should make them
together.
BTW, `defaultRingBufferSize` will be removed by
https://github.com/apache/yunikorn-core/pull/915, since its replacement is in
configs#const already.
> Consider moving event_system#defaultEventChannelSize to configs#const
> ---------------------------------------------------------------------
>
> Key: YUNIKORN-2756
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2756
> Project: Apache YuniKorn
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Priority: Trivial
>
> All other event-related configs are in configs#const[1], so we should move
> `defaultEventChannelSize`[0] make them together.
> BTW, `defaultRingBufferSize`[2] will be removed by
> https://github.com/apache/yunikorn-core/pull/915, since its replacement is in
> configs#const already [3]
> [0]
> https://github.com/apache/yunikorn-core/blob/f25bee90c2abd2c6682912dfdd0013ef2f4bc0ba/pkg/events/event_system.go#L37
> [1]
> https://github.com/apache/yunikorn-core/blob/f25bee90c2abd2c6682912dfdd0013ef2f4bc0ba/pkg/common/configs/configs.go#L43
> [2]
> https://github.com/apache/yunikorn-core/blob/f25bee90c2abd2c6682912dfdd0013ef2f4bc0ba/pkg/events/event_system.go#L38
> [3]
> https://github.com/apache/yunikorn-core/blob/f25bee90c2abd2c6682912dfdd0013ef2f4bc0ba/pkg/common/configs/configs.go#L47
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
