[
https://issues.apache.org/jira/browse/YUNIKORN-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866225#comment-17866225
]
Yu-Lin Chen commented on YUNIKORN-2757:
---------------------------------------
+1 for simplifying (sq *Queue) GetMaxResource.
# The recursive to root queue is hidden in GetMaxResource (), which is
unnecessary and never happens in current codebase. The
getHeadRoom()/internalHeadRoom() already cover the recursive check to root when
calculating headroom.
# There are some inconsistent function name in queue.go. I found that for
sq.guaranteeResource, there have GetGuaranteeResource() and
{*}GetActualGuaranteedResource(){*}. The second one include the check to root.
But for GetMaxResource(), it did the recursive check inside itself.
> Consider adding new field `resolvedMaxResource` to queue dao to show the true
> limit
> -----------------------------------------------------------------------------------
>
> Key: YUNIKORN-2757
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2757
> Project: Apache YuniKorn
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Priority: Major
>
> The true max resources of queue is based on all parents. It could be hard to
> see/understand the true "max resources" of queue by human eyes if there is a
> huge queue trees.
> Hence, it would be nice to add the "resolved" max resources to restful APIs.
> Also, our UI can leverages the field to help users to understand which max
> resource will be used by this queue
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
