[
https://issues.apache.org/jira/browse/YUNIKORN-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869703#comment-17869703
]
Yu-Lin Chen commented on YUNIKORN-2524:
---------------------------------------
[~ryankert], [~wilfreds] Sorry for the late review of the
[PR|https://github.com/apache/yunikorn-site/pull/459].
IMO, I think we should explain "recovery placement rule" on the "[App Placement
Rules|https://yunikorn.apache.org/docs/next/user_guide/placement_rules]"; pages
instead of explaining 'recover queue' on the "[Partition and Queue
Configuration|https://yunikorn.apache.org/docs/next/user_guide/queue_config#recovery-queue]";
page.
My reason is:
* The new root.@recovery@ queue is an outcome to solve placement rule change
after initialisation YUNIKORN-1793, and our original solution is always adding
the placement rule(recovery) to address the issue
([code|https://github.com/apache/yunikorn-core/blob/e36793f3e6b108fc370a430ab976fe3930b253a8/pkg/scheduler/placement/placement.go#L225-L226]).
There is nothing about "How to configure Partition and Queue" for users.
I prefer to explain the fifth rule in
[Rules|https://yunikorn.apache.org/docs/user_guide/placement_rules#rules], or
create another section to explain 'How we handle placement fails?' in placement
rule page.
Please feel free to share your thoughts. Thanks.
> add documentation for recovery queue (root.@recovery@)
> ------------------------------------------------------
>
> Key: YUNIKORN-2524
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2524
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: documentation
> Reporter: Chia-Ping Tsai
> Assignee: Hsien-Cheng(Ryan) Huang
> Priority: Major
> Labels: newbie, pull-request-available
>
> the recovery queue is unqueryable directly but we can observe the recovery
> queue name via app Restful API (`ws/v1/partition/%s/application/%s`).
> Hence, we should write documents for recovery queue. Otherwise, it would be
> surprise to users when they see the incomprehensible queue and they get
> nothing from our docs.
> some discussion on a pr review:
> https://github.com/apache/yunikorn-site/pull/426#discussion_r1588788027
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
