This is an automated email from the ASF dual-hosted git repository.
pbacsko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/yunikorn-core.git
The following commit(s) were added to refs/heads/master by this push:
new 3d6a5619 [YUNIKORN-2429] Enhance UGM Manager test coverage (#931)
3d6a5619 is described below
commit 3d6a561998f1a6cb6d415d8b248cc419de604e0c
Author: Peter Bacsko <[email protected]>
AuthorDate: Mon Aug 12 17:23:39 2024 +0200
[YUNIKORN-2429] Enhance UGM Manager test coverage (#931)
Closes: #931
Signed-off-by: Peter Bacsko <[email protected]>
---
pkg/scheduler/ugm/manager_test.go | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/pkg/scheduler/ugm/manager_test.go
b/pkg/scheduler/ugm/manager_test.go
index 040602a7..91d70257 100644
--- a/pkg/scheduler/ugm/manager_test.go
+++ b/pkg/scheduler/ugm/manager_test.go
@@ -359,6 +359,7 @@ func TestUseWildCard(t *testing.T) {
// clear all configs. Since wild card user limit is not there, all
users used its settings earlier under the same queue path should start using
its own value
conf = createConfigWithoutLimits()
+ manager.IncreaseTrackedResource(queuePath2, TestApp2, usage, user2)
assert.NilError(t, manager.UpdateConfig(conf.Queues[0], "root"), err)
headroom = manager.Headroom(queuePath1, TestApp1, user1)
@@ -371,6 +372,13 @@ func TestUseWildCard(t *testing.T) {
assert.Assert(t,
resources.Equals(manager.GetUserTracker(user1.User).queueTracker.childQueueTrackers["parent"].maxResources,
nil))
assert.Assert(t,
resources.Equals(manager.GetUserTracker(user1.User).queueTracker.childQueueTrackers["parent"].childQueueTrackers["child1"].maxResources,
nil))
+ assert.Equal(t,
manager.GetUserTracker(user2.User).queueTracker.maxRunningApps, uint64(0))
+ assert.Equal(t,
manager.GetUserTracker(user2.User).queueTracker.childQueueTrackers["parent"].maxRunningApps,
uint64(0))
+ assert.Equal(t,
manager.GetUserTracker(user2.User).queueTracker.childQueueTrackers["parent"].childQueueTrackers["child1"].maxRunningApps,
uint64(0))
+ assert.Assert(t,
resources.Equals(manager.GetUserTracker(user2.User).queueTracker.maxResources,
nil))
+ assert.Assert(t,
resources.Equals(manager.GetUserTracker(user2.User).queueTracker.childQueueTrackers["parent"].maxResources,
nil))
+ assert.Assert(t,
resources.Equals(manager.GetUserTracker(user2.User).queueTracker.childQueueTrackers["parent"].childQueueTrackers["child1"].maxResources,
nil))
+
// set limit for user1 explicitly. New limit should precede the wild
card user limit
conf = createUpdateConfigWithWildCardUsersAndGroups(user1.User,
user1.Groups[0], "", "", "50", "50")
assert.NilError(t, manager.UpdateConfig(conf.Queues[0], "root"))
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
