[
https://issues.apache.org/jira/browse/YUNIKORN-2908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888096#comment-17888096
]
Craig Condit edited comment on YUNIKORN-2908 at 10/9/24 11:56 PM:
------------------------------------------------------------------
This is actually much more complex than it initially appears. We should split
this Jira up into separate tasks for queue deletion and guaranteed / pending /
max changing. The queue removal can simply be removal of the entire metrics
object. The dynamic updates for the other metrics are more complex. I'd prefer
to take that task myself.
[~hguo25] can you split this out please?
was (Author: ccondit):
This is actually much more complex than it initially appears. We should split
this Jira up into separate tasks for queue deletion and guaranteed / pending /
max changing. The queue removal can simply be removal of the entire metrics
object. The dynamic updates for the other metrics are more complex. I'd prefer
to take that task myself.
> metrics not removed when queue or queue's guaranteed/max resource config is
> removed
> -----------------------------------------------------------------------------------
>
> Key: YUNIKORN-2908
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2908
> Project: Apache YuniKorn
> Issue Type: Bug
> Reporter: Hengzhe Guo
> Assignee: Hengzhe Guo
> Priority: Major
>
> 1. after a queue is removed, its metrics will continue to be reported by
> prometheus. This is fine with metrics like allocated resource because they
> will just be 0, but it won't make sense for guaranteed and max resources,
> giving wrong impression that there are still resource given to the queue. I
> propose to unregister all this queue's metrics when it's removed.
> 2. If queue is not removed but guaranteed or max resource config is removed,
> or just a resource type is removed from the config, the metrics are also not
> cleaned up. these metrics are only updated when there's a new valid value,
> but not 'null' value. I propose to always delete all existing guaranteed and
> max resources metrics of the queue then add back the new values, every time
> we apply the configs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
