This is an automated email from the ASF dual-hosted git repository.
ccondit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/yunikorn-core.git
The following commit(s) were added to refs/heads/master by this push:
new 19fefc6b [YUNIKORN-2951] Remove unnecessary locking from
RequiredNodePreemptor (#989)
19fefc6b is described below
commit 19fefc6b02d438a11eac0cc7c92d29154bd37085
Author: Ryan <[email protected]>
AuthorDate: Tue Oct 29 14:52:32 2024 -0500
[YUNIKORN-2951] Remove unnecessary locking from RequiredNodePreemptor (#989)
Closes: #989
Signed-off-by: Craig Condit <[email protected]>
---
pkg/scheduler/objects/required_node_preemptor.go | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/pkg/scheduler/objects/required_node_preemptor.go
b/pkg/scheduler/objects/required_node_preemptor.go
index 507eb868..821a7ea4 100644
--- a/pkg/scheduler/objects/required_node_preemptor.go
+++ b/pkg/scheduler/objects/required_node_preemptor.go
@@ -22,15 +22,12 @@ import (
"sort"
"github.com/apache/yunikorn-core/pkg/common/resources"
- "github.com/apache/yunikorn-core/pkg/locking"
)
type PreemptionContext struct {
node *Node
requiredAsk *Allocation
allocations []*Allocation
-
- locking.RWMutex
}
func NewRequiredNodePreemptor(node *Node, requiredAsk *Allocation)
*PreemptionContext {
@@ -43,8 +40,6 @@ func NewRequiredNodePreemptor(node *Node, requiredAsk
*Allocation) *PreemptionCo
}
func (p *PreemptionContext) filterAllocations() {
- p.Lock()
- defer p.Unlock()
for _, allocation := range p.node.GetYunikornAllocations() {
// skip daemon set pods and higher priority allocation
if allocation.GetRequiredNode() != "" ||
allocation.GetPriority() > p.requiredAsk.GetPriority() {
@@ -76,8 +71,6 @@ func (p *PreemptionContext) filterAllocations() {
// 3. By Create time or age of the ask (younger ask placed first),
// 4. By resource (ask with lesser allocated resources placed first)
func (p *PreemptionContext) sortAllocations() {
- p.Lock()
- defer p.Unlock()
sort.SliceStable(p.allocations, func(i, j int) bool {
l := p.allocations[i]
r := p.allocations[j]
@@ -129,8 +122,6 @@ func (p *PreemptionContext) sortAllocations() {
}
func (p *PreemptionContext) GetVictims() []*Allocation {
- p.RLock()
- defer p.RUnlock()
var victims []*Allocation
var currentResource = resources.NewResource()
for _, allocation := range p.allocations {
@@ -152,7 +143,5 @@ func (p *PreemptionContext) GetVictims() []*Allocation {
// for test only
func (p *PreemptionContext) getAllocations() []*Allocation {
- p.RLock()
- defer p.RUnlock()
return p.allocations
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
