[
https://issues.apache.org/jira/browse/YUNIKORN-2964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko updated YUNIKORN-2964:
-----------------------------------
Description:
When we run plugins in the prefilter phase, we maintain a list of nodes (called
"mergedNodes") and we check if the current node is included or not after we run
a plugin.
If the node is not listed, we don't log which plugin made this decision. To
enhance supportability, we should include the plugin name in the returned
message:
{noformat}
mergedNodes = mergedNodes.Merge(nodes)
if !mergedNodes.AllNodes() && !mergedNodes.NodeNames.Has(node.Node().Name) {
return framework.NewStatus(framework.UnschedulableAndUnresolvable, "node
not eligible"), plugin, skip
} {noformat}
was:
When we run plugins in the prefilter phase, we maintain a list of nodes (called
"mergedNodes") and we check if the current node is included or not after we run
a plugin.
Right now we don't log which plugin made this decision. To enhance
supportability, we should include the plugin name in the returned message:
{noformat}
mergedNodes = mergedNodes.Merge(nodes)
if !mergedNodes.AllNodes() && !mergedNodes.NodeNames.Has(node.Node().Name) {
return framework.NewStatus(framework.UnschedulableAndUnresolvable, "node
not eligible"), plugin, skip
} {noformat}
> Enhance the error message "node not eligible"
> ---------------------------------------------
>
> Key: YUNIKORN-2964
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2964
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Minor
>
> When we run plugins in the prefilter phase, we maintain a list of nodes
> (called "mergedNodes") and we check if the current node is included or not
> after we run a plugin.
> If the node is not listed, we don't log which plugin made this decision. To
> enhance supportability, we should include the plugin name in the returned
> message:
> {noformat}
> mergedNodes = mergedNodes.Merge(nodes)
> if !mergedNodes.AllNodes() && !mergedNodes.NodeNames.Has(node.Node().Name) {
> return framework.NewStatus(framework.UnschedulableAndUnresolvable, "node
> not eligible"), plugin, skip
> } {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
