[
https://issues.apache.org/jira/browse/YUNIKORN-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898517#comment-17898517
]
Tzu-Hua Lan commented on YUNIKORN-2975:
---------------------------------------
Hi [~wilfreds]
After my research:
1. It's technically not possible for a Dockerfile to directly read .nvmrc as a
base image tag due to Dockerfile's limitations.
2. As far as I know, Dockerfile is often built through Makefile by `make
image`, which can already handle version synchronization by passing the .nvmrc
value via the `--build-arg` parameter.
3. I also noticed there's another place where Node.js version needs to be
synchronized - the `engines` property in package.json.
Based on these points, it seems manually updating Node.js version in these
three locations is inevitable.
> web image build does not use .nvmrc
> -----------------------------------
>
> Key: YUNIKORN-2975
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2975
> Project: Apache YuniKorn
> Issue Type: Task
> Components: webapp
> Reporter: Wilfred Spiegelenburg
> Assignee: Tzu-Hua Lan
> Priority: Major
>
> In the Docker file we use to build the image we have hardcoded a version of
> node.
> {code:java}
> ARG NODE_VERSION=20
> # Buildstage: use the local architecture
> FROM --platform=$BUILDPLATFORM node:${NODE_VERSION}-alpine AS buildstage
> {code}
> This causes issues as the real version that it points to can change from one
> build to another. We should be using the version we set in the {{.nvmrc}} as
> that would also be the version we install as a tool and that has been used by
> the developer.
> Currently the versions are also out of sync 18.20 vs 20.
> Part of the change we should also move to node 22.11.0 to get to the latest
> LTS that is supported with the angular release we use.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
