This is an automated email from the ASF dual-hosted git repository.
mani pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/yunikorn-core.git
The following commit(s) were added to refs/heads/master by this push:
new 29e15962 [YUNIKORN-3005] Increase decreaseTrackedResource test
coverage (#1010) Closes: #1010
29e15962 is described below
commit 29e15962d37711d8fc11c3f103a3bed8d9c58a24
Author: Ryan <[email protected]>
AuthorDate: Wed Jan 8 13:39:54 2025 +0530
[YUNIKORN-3005] Increase decreaseTrackedResource test coverage (#1010)
Closes: #1010
Signed-off-by: Manikandan R <[email protected]>
---
pkg/scheduler/ugm/manager_test.go | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/pkg/scheduler/ugm/manager_test.go
b/pkg/scheduler/ugm/manager_test.go
index 4edc6ce4..9768cb28 100644
--- a/pkg/scheduler/ugm/manager_test.go
+++ b/pkg/scheduler/ugm/manager_test.go
@@ -695,6 +695,7 @@ func TestDecreaseTrackedResourceForGroupTracker(t
*testing.T) {
setupUGM()
// Queue setup:
// root->parent
+ // case 1: DecreaseTrackedResource with specified config limits
user := security.UserGroup{User: "user1", Groups: []string{"group1"}}
conf := createConfigWithoutLimits()
conf.Queues[0].Queues[0].Limits = []configs.Limit{
@@ -720,11 +721,24 @@ func TestDecreaseTrackedResourceForGroupTracker(t
*testing.T) {
assert.Equal(t,
resources.Equals(groupTracker.queueTracker.childQueueTrackers["parent"].resourceUsage,
usage), true)
manager.DecreaseTrackedResource("root.parent", TestApp1, usage, user,
true)
-
groupTracker = m.GetGroupTracker(user.Groups[0])
assert.Equal(t, groupTracker != nil, true)
assert.Equal(t,
groupTracker.queueTracker.childQueueTrackers["parent"].runningApplications[TestApp1],
false)
assert.Equal(t,
resources.Equals(groupTracker.queueTracker.childQueueTrackers["parent"].resourceUsage,
resources.Zero), true)
+
+ // case 2: DecreaseTrackedResource with nil config limits
+ manager.IncreaseTrackedResource("root.parent", TestApp1, usage, user)
+ groupTracker = m.GetGroupTracker(user.Groups[0])
+ assert.Equal(t, groupTracker != nil, true)
+ assert.Equal(t,
groupTracker.queueTracker.childQueueTrackers["parent"].runningApplications[TestApp1],
true)
+ assert.Equal(t,
resources.Equals(groupTracker.queueTracker.childQueueTrackers["parent"].resourceUsage,
usage), true)
+
+ conf.Queues[0].Queues[0].Limits = nil
+ assert.NilError(t, manager.UpdateConfig(conf.Queues[0], "root"))
+
+ manager.DecreaseTrackedResource("root.parent", TestApp1, usage, user,
true)
+ groupTracker = m.GetGroupTracker(user.Groups[0])
+ assert.Equal(t, groupTracker == nil, true)
}
func TestIncreaseTrackedResourceForGroupTracker(t *testing.T) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
