[
https://issues.apache.org/jira/browse/YUNIKORN-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu-Lin Chen updated YUNIKORN-3017:
----------------------------------
Description:
The E2E test suites are separated into two files: XXX_suite_test.go and
XXX_test.go.
The former contains suite-level variable and suite-level setup/teardown. The
later is focus on test logic and test-level setup/teardown.
However, some test suites mixed up the separation . For example:
# BeforeSuite/AfterSuite are set in persistent_volume_test.go instead of
persistent_volume_suite_test.go
# BeforeSuite/AfterSuite are set in preemption_test.go instead of
preemption_suite_test.go
# BeforeSuite/AfterSuite set in basic_scheduling_test.go instead of
basic_scheduling_suite_test.go
# BeforeSuite/AfterSuite set in recovery_and_restart_test.go instead of
recovery_and_restart_suite_test.go
# BeforeSuite/AfterSuite set in restart_changed_config_test.go instead of
restart_changed_config_suite_test.go
# BeforeSuite/AfterSuite set in simple_preemptor_test.go instead of
simple_preemptor_suite_test.go
# BeforeSuite/AfterSuite set in user_group_limit.go instead of
user_group_limit_suite_test.go
Below test suites are in good shape:
# admission_controller
# bin_packing
# configmap_suite_test
# foreign_pod
# gang_scheduling
# node_resources
# predicates
# priority_scheduling
# queue_quota_mgmt
# resource_fairness
# spark_jobs_scheduling
Above is a rough review so I may missed something,
The main goal of this Jira is to reshape the test code to a consist structure.
We can create a subtask for each test suite.
was:
The E2E test suites are separated into two files: XXX_suite_test.go and
XXX_test.go.
The former contains suite-level variable and suite-level setup/teardown. The
later is focus on test logic and test-level setup/teardown.
However, some test suites mixed up the separation . For example:
# BeforeSuite/AfterSuite are set in persistent_volume_test.go instead of
persistent_volume_suite_test.go
# BeforeSuite/AfterSuite are set in preemption_test.go instead of
preemption_suite_test.go
# BeforeSuite/AfterSuite set in basic_scheduling_test.go instead of
basic_scheduling_suite_test.go
# BeforeSuite/AfterSuite set in recovery_and_restart_test.go instead of
recovery_and_restart_suite_test.go
# BeforeSuite/AfterSuite set in restart_changed_config_test.go instead of
restart_changed_config_suite_test.go
# BeforeSuite/AfterSuite set in simple_preemptor_test.go instead of
simple_preemptor_suite_test.go
# BeforeSuite/AfterSuite set in user_group_limit.go instead of
user_group_limit_suite_test.go
Below test suites are in good shape:
# admission_controller
# bin_packing
# configmap_suite_test
# foreign_pod
# gang_scheduling
# node_resources
# predicates
# priority_scheduling
# queue_quota_mgmt
# resource_fairness
# spark_jobs_scheduling
Above is a rough review so I may missed something,
The main goal of this Jira is to reshape the test code to a consist struture.
We can create a subtask for each test suite.
> [UMBRELLA] Refactor E2E test suites to a consistent code structure
> ------------------------------------------------------------------
>
> Key: YUNIKORN-3017
> URL: https://issues.apache.org/jira/browse/YUNIKORN-3017
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: test - e2e
> Reporter: Yu-Lin Chen
> Assignee: Yu-Lin Chen
> Priority: Major
>
> The E2E test suites are separated into two files: XXX_suite_test.go and
> XXX_test.go.
> The former contains suite-level variable and suite-level setup/teardown. The
> later is focus on test logic and test-level setup/teardown.
> However, some test suites mixed up the separation . For example:
> # BeforeSuite/AfterSuite are set in persistent_volume_test.go instead of
> persistent_volume_suite_test.go
> # BeforeSuite/AfterSuite are set in preemption_test.go instead of
> preemption_suite_test.go
> # BeforeSuite/AfterSuite set in basic_scheduling_test.go instead of
> basic_scheduling_suite_test.go
> # BeforeSuite/AfterSuite set in recovery_and_restart_test.go instead of
> recovery_and_restart_suite_test.go
> # BeforeSuite/AfterSuite set in restart_changed_config_test.go instead of
> restart_changed_config_suite_test.go
> # BeforeSuite/AfterSuite set in simple_preemptor_test.go instead of
> simple_preemptor_suite_test.go
> # BeforeSuite/AfterSuite set in user_group_limit.go instead of
> user_group_limit_suite_test.go
> Below test suites are in good shape:
> # admission_controller
> # bin_packing
> # configmap_suite_test
> # foreign_pod
> # gang_scheduling
> # node_resources
> # predicates
> # priority_scheduling
> # queue_quota_mgmt
> # resource_fairness
> # spark_jobs_scheduling
> Above is a rough review so I may missed something,
> The main goal of this Jira is to reshape the test code to a consist
> structure. We can create a subtask for each test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
