This is an automated email from the ASF dual-hosted git repository.
mani pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/yunikorn-web.git
The following commit(s) were added to refs/heads/master by this push:
new a1ab49e [YUNIKORN-3200] install chrome for testing if missing (#249)
a1ab49e is described below
commit a1ab49ea0bb775b7f5da1bf4b00e343f63e55294
Author: Wilfred Spiegelenburg <[email protected]>
AuthorDate: Thu Feb 5 12:59:10 2026 +0530
[YUNIKORN-3200] install chrome for testing if missing (#249)
If "Chrome for Testing" is missing, i.e. version mimatch, let puppeteer
install the correct version. This happens if the puppeteer version used
is defaulting to a different release than available on the node running
the build. This can happen on a local machine or in CI (GH action).
Closes: #249
Signed-off-by: Manikandan R <[email protected]>
---
Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 273a248..5b53675 100644
--- a/Makefile
+++ b/Makefile
@@ -156,7 +156,8 @@ tools: $(PNPM_BIN) $(NG_BIN) $(GOLANGCI_LINT_BIN)
# Install deps
.PHONY: deps
deps: tools
- PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1 && $(PNPM_BIN) i
+ $(PNPM_BIN) i
+ $(PNPM_BIN) dlx puppeteer browsers install
# Install pnpm
$(PNPM_BIN):
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
