[ 
https://issues.apache.org/jira/browse/YUNIKORN-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18066920#comment-18066920
 ] 

Victor Zhou commented on YUNIKORN-3241:
---------------------------------------

https://github.com/apache/yunikorn-core/pull/1076

> Fence root search bug when queue is at max capacity
> ---------------------------------------------------
>
>                 Key: YUNIKORN-3241
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-3241
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: core - scheduler
>            Reporter: Victor Zhou
>            Priority: Major
>              Labels: Yunikorn-core, bug, preemption, pull-request-available
>             Fix For: 1.9.0
>
>
> h3. Description
> [findPreemptionFenceRoot() 
> |https://github.com/apache/yunikorn-core/blob/master/pkg/scheduler/objects/queue.go#L2201]in
>  pkg/scheduler/objects/queue.go only fenced on max when allocated == max.
> Allocated equals max exactly is a pretty rare case, and this misses cases 
> where a queue is not yet full, but the incoming ask would bring it to or 
> beyond max (allocated + ask >= max), causing preemption scope to be computed 
> too broadly.
> h3. Root Cause
> Fence-root max check was based on current allocation equality only, without 
> considering the pending ask resource.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to