[
https://issues.apache.org/jira/browse/YUNIKORN-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18099142#comment-18099142
]
KAI-JAY TU commented on YUNIKORN-3320:
--------------------------------------
Hi, I noticed that commit 3dbbb5d (YUNIKORN-3318) already added an
ask.GetRequiredNode() == "" guard to the reservation timeout check in
tryReservedAllocate, which prevents required node reservations from being
released on timeout. Could you confirm whether this fix fully addresses the
issue, or if there are additional scenarios that still need to be handled? I'm
happy to add test coverage for the fix if needed.
> tryReservedAllocate can release required node reservations
> ----------------------------------------------------------
>
> Key: YUNIKORN-3320
> URL: https://issues.apache.org/jira/browse/YUNIKORN-3320
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: core - scheduler
> Affects Versions: 1.9.0
> Reporter: Wilfred Spiegelenburg
> Priority: Major
> Labels: newbie
>
> {{tryReservedAllocate}} cleans up reservations that should not be on the node
> any more: reservation is older than the {{reservationWaitTimeout}}. This does
> not take into account that there might be other required node reservations on
> that same node.
> Required node reservations should not be released from a node even if they
> are older than the timeout
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
