[
https://issues.apache.org/jira/browse/YUNIKORN-3451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18114599#comment-18114599
]
Wilfred Spiegelenburg commented on YUNIKORN-3451:
-------------------------------------------------
There were more issues in the code that needed streamlining. The build was
jumping all over the place instead of using {{cwd}} in the commands that were
run.
Generating the repro SHAs also build the tar twice and still did not allow the
image build to work on the staging directory. All build activity in the image
build as well as the release build now use one staging setup.
The version information in the README was also incorrect. The repro version was
not mentioned and the minimal go version was stuck on 1.24 after an earlier
change as the replace would fail. Yarn was still mentioned as the build infra
for the web UI and that had moved to pnpm. Angular and node versions were
either not changing same as the go version or pointing to the incorrect
dependency.
> replace subprocess call with run
> --------------------------------
>
> Key: YUNIKORN-3451
> URL: https://issues.apache.org/jira/browse/YUNIKORN-3451
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: release
> Reporter: Wilfred Spiegelenburg
> Assignee: Wilfred Spiegelenburg
> Priority: Major
>
> Python {{subprocess.call}} has been deprecated and we should be moving to
> {{{}subprocess.run{}}}.
> Clean up and make sure the stdout and stderr get logged correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
